Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cannot upload image when creating a new post in UC editor #5114

Merged
merged 1 commit into from Dec 27, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Dec 27, 2023

What type of PR is this?

/area console
/kind bug
/milestone 2.12.x

What this PR does / why we need it:

修复在个人中心的文章编辑器中创建新文章时无法上传图片的问题

Which issue(s) this PR fixes:

Fixes #5035

Special notes for your reviewer:

测试在 UC 新建文章,在未保存时是否能上传图片。

Does this PR introduce a user-facing change?

修复个人中心创建新文章时无法上传图片的问题

@f2c-ci-robot f2c-ci-robot bot added area/console Issues or PRs related to the Halo Console release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Dec 27, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.12.x milestone Dec 27, 2023
@f2c-ci-robot f2c-ci-robot bot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 27, 2023
@f2c-ci-robot f2c-ci-robot bot modified the milestones: 2.12.x, 2.11.3 Dec 27, 2023
@ruibaby ruibaby modified the milestones: 2.11.3, 2.12.x Dec 27, 2023
@ruibaby
Copy link
Member Author

ruibaby commented Dec 27, 2023

/cherry-pick release-2.11

@halo-dev-bot
Copy link
Collaborator

@ruibaby: once the present PR merges, I will cherry-pick it on top of release-2.11 in a new PR and assign it to you.

In response to this:

/cherry-pick release-2.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e778992) 55.91% compared to head (17a571c) 55.91%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5114   +/-   ##
=========================================
  Coverage     55.91%   55.91%           
  Complexity     3032     3032           
=========================================
  Files           524      524           
  Lines         17826    17826           
  Branches       1329     1329           
=========================================
  Hits           9968     9968           
  Misses         7309     7309           
  Partials        549      549           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented Dec 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 27, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 27, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 285ac6a into halo-dev:main Dec 27, 2023
4 checks passed
@ruibaby ruibaby deleted the fix/uc-editor-upload branch December 27, 2023 03:50
@halo-dev-bot
Copy link
Collaborator

@ruibaby: new pull request created: #5115

In response to this:

/cherry-pick release-2.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

编辑粘贴图片BUG
3 participants