Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve role dependency-related functions and i18n #5227

Merged
merged 3 commits into from Jan 24, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jan 22, 2024

What type of PR is this?

/area console
/area core
/milestone 2.12.x

What this PR does / why we need it:

优化角色模板依赖的相关功能:

  1. 修复勾选某个角色模板之后,其下依赖模板没有选中的问题。
  2. 修复编辑角色时,模板其下依赖模板没有选中的问题。
  3. 修复角色管理列表中,权限数量显示有误的问题。
  4. 移除 允许管理所有文章 的角色模板,此角色模板与文章管理重复。
  5. 优化 i18n。

Which issue(s) this PR fixes:

Fixes #5222

Special notes for your reviewer:

需要测试上诉问题是否还存在。

Does this PR introduce a user-facing change?

优化角色模板依赖的相关功能,优化文章相关角色的翻译。

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 22, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.12.x milestone Jan 22, 2024
@f2c-ci-robot f2c-ci-robot bot added area/console Issues or PRs related to the Halo Console area/core Issues or PRs related to the Halo Core labels Jan 22, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from Aanko and wan92hen January 22, 2024 08:15
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (95878b3) 57.06% compared to head (3911fd4) 57.06%.
Report is 3 commits behind head on main.

❗ Current head 3911fd4 differs from pull request most recent head 517adce. Consider uploading reports for the commit 517adce to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5227   +/-   ##
=========================================
  Coverage     57.06%   57.06%           
  Complexity     3333     3333           
=========================================
  Files           584      584           
  Lines         19190    19190           
  Branches       1444     1444           
=========================================
  Hits          10950    10950           
  Misses         7664     7664           
  Partials        576      576           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Ryan Wang <i@ryanc.cc>
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2024
@JohnNiang JohnNiang added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2024
Copy link

f2c-ci-robot bot commented Jan 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 28ee0bf into halo-dev:main Jan 24, 2024
7 checks passed
@ruibaby ruibaby deleted the refactor/role branch January 24, 2024 02:35
@ruibaby ruibaby modified the milestones: 2.12.x, 2.12.0 Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console area/core Issues or PRs related to the Halo Core lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"投稿者"和"作者"角色拥有的权限貌似和语义不符
3 participants