New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: improve role dependency-related functions and i18n #5227
Conversation
Signed-off-by: Ryan Wang <i@ryanc.cc>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5227 +/- ##
=========================================
Coverage 57.06% 57.06%
Complexity 3333 3333
=========================================
Files 584 584
Lines 19190 19190
Branches 1444 1444
=========================================
Hits 10950 10950
Misses 7664 7664
Partials 576 576 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Ryan Wang <i@ryanc.cc>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/area console
/area core
/milestone 2.12.x
What this PR does / why we need it:
优化角色模板依赖的相关功能:
Which issue(s) this PR fixes:
Fixes #5222
Special notes for your reviewer:
需要测试上诉问题是否还存在。
Does this PR introduce a user-facing change?