New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: text selected after resolving the table cannot be deleted #5234
fix: text selected after resolving the table cannot be deleted #5234
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5234 +/- ##
=========================================
Coverage 57.05% 57.05%
Complexity 3332 3332
=========================================
Files 584 584
Lines 19189 19189
Branches 1444 1444
=========================================
Hits 10949 10949
Misses 7664 7664
Partials 576 576 ☔ View full report in Codecov by Sentry. |
/milestone 2.12.x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
当我点击表格开头的六点操作图标
选中表格时无法删除,请帮我确认一下是否符合预期
这个问题确实很奇怪,理论上来说点击拖拽图标与点击全选是一样的操作,但可能是由于编辑器焦点的问题导致无法删除。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
当表格后存在选中的内容时,按下退格键或删除键不再执行选中表格的操作,而是继续向下执行。
How to test it?
在表格后紧跟着文本,从文本开头选中文本,然后按下退格键,查看文本是否能够被删除。
Which issue(s) this PR fixes:
Fixes #5193
Does this PR introduce a user-facing change?