Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: text selected after resolving the table cannot be deleted #5234

Merged
merged 1 commit into from Jan 24, 2024

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Jan 23, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

当表格后存在选中的内容时,按下退格键或删除键不再执行选中表格的操作,而是继续向下执行。

How to test it?

在表格后紧跟着文本,从文本开头选中文本,然后按下退格键,查看文本是否能够被删除。

Which issue(s) this PR fixes:

Fixes #5193

Does this PR introduce a user-facing change?

解决默认富文本编辑器中表格后的文本选中后无法删除的问题

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Jan 23, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from Aanko and ruibaby January 23, 2024 07:16
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9d9b152) 57.05% compared to head (3c6e813) 57.05%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5234   +/-   ##
=========================================
  Coverage     57.05%   57.05%           
  Complexity     3332     3332           
=========================================
  Files           584      584           
  Lines         19189    19189           
  Branches       1444     1444           
=========================================
  Hits          10949    10949           
  Misses         7664     7664           
  Partials        576      576           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LIlGG
Copy link
Member Author

LIlGG commented Jan 23, 2024

/milestone 2.12.x

@f2c-ci-robot f2c-ci-robot bot added this to the 2.12.x milestone Jan 23, 2024
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

当我点击表格开头的六点操作图标选中表格时无法删除,请帮我确认一下是否符合预期

@LIlGG
Copy link
Member Author

LIlGG commented Jan 23, 2024

当我点击表格开头的六点操作图标选中表格时无法删除,请帮我确认一下是否符合预期

这个问题确实很奇怪,理论上来说点击拖拽图标与点击全选是一样的操作,但可能是由于编辑器焦点的问题导致无法删除。
但目前实际上并没有点击拖拽图标的处理,因此这个问题算是在预期之内,可以单独提一个 issue 用来解决这个问题。

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2024
Copy link

f2c-ci-robot bot commented Jan 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit ddbc73b into halo-dev:main Jan 24, 2024
7 checks passed
@ruibaby ruibaby modified the milestones: 2.12.x, 2.12.0 Jan 25, 2024
@LIlGG LIlGG deleted the fix/table-text-unable-to-delete branch February 1, 2024 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

默认富文本编辑器中紧跟表格后的文本选中后无法删除
3 participants