Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve effect of menu expand #5244

Merged
merged 2 commits into from Jan 25, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jan 24, 2024

What type of PR is this?

/area console
/milestone 2.12.x
/kind improvement

What this PR does / why we need it:

优化 Console 左侧菜单的展开逻辑,改为可以通过点击展开图标来展开子菜单。

image

Does this PR introduce a user-facing change?

优化 Console 左侧菜单的展开逻辑,支持通过点击图标来展开子菜单。

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added area/console Issues or PRs related to the Halo Console release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/improvement Categorizes issue or PR as related to a improvement. labels Jan 24, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.12.x milestone Jan 24, 2024
Signed-off-by: Ryan Wang <i@ryanc.cc>
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (14580b9) 57.06% compared to head (a2d5ec3) 57.18%.
Report is 10 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5244      +/-   ##
============================================
+ Coverage     57.06%   57.18%   +0.12%     
- Complexity     3333     3384      +51     
============================================
  Files           584      587       +3     
  Lines         19190    19235      +45     
  Branches       1444     1460      +16     
============================================
+ Hits          10950    10999      +49     
+ Misses         7664     7652      -12     
- Partials        576      584       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented Jan 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2024
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 138af65 into halo-dev:main Jan 25, 2024
7 checks passed
@ruibaby ruibaby modified the milestones: 2.12.x, 2.12.0 Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants