Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve the issue of the bubble menu being obscured #5246

Merged
merged 1 commit into from Jan 25, 2024

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Jan 24, 2024

What type of PR is this?

/kind bug
/area console
/area editor

What this PR does / why we need it:

将默认编辑器的父级容器移除。用于解决冒泡菜单被遮挡的问题。
由于修改后默认编辑器自身可滚动,因此可以使默认编辑器容器内的绝对定位元素获取到当前滚动的位置。

How to test it?

输入超过一屏宽度的内容,按 MOD + A 全选,查看冒泡菜单是否被顶部菜单遮挡。

Which issue(s) this PR fixes:

Fixes #4869

Does this PR introduce a user-facing change?

解决编辑器冒泡菜单会被顶部工具栏遮挡的问题。

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Jan 24, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and ruibaby January 24, 2024 10:12
@f2c-ci-robot f2c-ci-robot bot added area/console Issues or PRs related to the Halo Console area/editor Issues or PRs related to the Editor labels Jan 24, 2024
@LIlGG
Copy link
Member Author

LIlGG commented Jan 24, 2024

/milestone 2.12.x

@f2c-ci-robot f2c-ci-robot bot added this to the 2.12.x milestone Jan 24, 2024
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3846525) 57.18% compared to head (4478c8d) 57.18%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5246   +/-   ##
=========================================
  Coverage     57.18%   57.18%           
  Complexity     3384     3384           
=========================================
  Files           587      587           
  Lines         19235    19235           
  Branches       1460     1460           
=========================================
  Hits          10999    10999           
  Misses         7652     7652           
  Partials        584      584           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented Jan 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit cecdb3f into halo-dev:main Jan 25, 2024
7 checks passed
@ruibaby ruibaby modified the milestones: 2.12.x, 2.12.0 Jan 25, 2024
@LIlGG LIlGG deleted the fix/floating-box-being-obscured branch February 1, 2024 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console area/editor Issues or PRs related to the Editor kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

默认编辑器的悬浮工具栏可能会被挡住造成无法完整显示
4 participants