Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the order of contributors for posts is not fixed #5279

Merged
merged 1 commit into from Jan 30, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Jan 30, 2024

What type of PR is this?

/kind improvement
/area core
/milestone 2.12.x

What this PR does / why we need it:

修复文章列表的 contributors 顺序不固定的问题

Does this PR introduce a user-facing change?

修复文章列表的贡献者数据顺序不固定的问题

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a4e862c) 57.07% compared to head (a5b0e86) 57.08%.
Report is 2 commits behind head on main.

Files Patch % Lines
...ava/run/halo/app/content/impl/PostServiceImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5279   +/-   ##
=========================================
  Coverage     57.07%   57.08%           
- Complexity     3329     3330    +1     
=========================================
  Files           587      587           
  Lines         18956    18956           
  Branches       1402     1402           
=========================================
+ Hits          10820    10821    +1     
+ Misses         7558     7557    -1     
  Partials        578      578           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JohnNiang JohnNiang added area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. labels Jan 30, 2024
@JohnNiang JohnNiang added this to the 2.12.0 milestone Jan 30, 2024
@guqing guqing force-pushed the bugfix/order-for-contributors branch from 0e73a17 to a5b0e86 Compare January 30, 2024 07:51
Copy link

sonarcloud bot commented Jan 30, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.3% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented Jan 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2024
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@JohnNiang JohnNiang added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2024
@JohnNiang JohnNiang merged commit c792cef into halo-dev:main Jan 30, 2024
7 of 8 checks passed
@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 30, 2024
@guqing guqing deleted the bugfix/order-for-contributors branch January 30, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants