Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unnecessary indices build process for lucene on startup #5332

Merged

Conversation

guqing
Copy link
Member

@guqing guqing commented Feb 5, 2024

What type of PR is this?

/kind cleanup
/area core
/milestone 2.13.x

What this PR does / why we need it:

移除启动时不必要的搜索引擎索引构建步骤

Does this PR introduce a user-facing change?

移除启动时不必要的搜索引擎索引构建步骤

@guqing
Copy link
Member Author

guqing commented Feb 5, 2024

/cherry-pick release-2.12

Copy link

sonarcloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.3% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dcef5d4) 57.14% compared to head (a3b3f36) 56.91%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5332      +/-   ##
============================================
- Coverage     57.14%   56.91%   -0.24%     
+ Complexity     3335     3319      -16     
============================================
  Files           587      587              
  Lines         18977    18968       -9     
  Branches       1402     1401       -1     
============================================
- Hits          10844    10795      -49     
- Misses         7555     7594      +39     
- Partials        578      579       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

同意,每次启动时都查询所有已发布的文章确实不太合理。

@JohnNiang JohnNiang added lgtm Indicates that a PR is ready to be merged. area/core Issues or PRs related to the Halo Core kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 5, 2024
@JohnNiang JohnNiang added this to the 2.13.x milestone Feb 5, 2024
@JohnNiang
Copy link
Member

/cherry-pick release-2.12

@halo-dev-bot
Copy link
Collaborator

@JohnNiang: once the present PR merges, I will cherry-pick it on top of release-2.12 in a new PR and assign it to you.

In response to this:

/cherry-pick release-2.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

f2c-ci-robot bot commented Feb 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 7341f9d into halo-dev:main Feb 5, 2024
8 checks passed
@halo-dev-bot
Copy link
Collaborator

@guqing: new pull request created: #5333

In response to this:

/cherry-pick release-2.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

f2c-ci-robot bot pushed a commit that referenced this pull request Feb 5, 2024
…cene on startup (#5333)

This is an automated cherry-pick of #5332

/assign guqing

```release-note
移除启动时不必要的搜索引擎索引构建步骤
```
@ruibaby ruibaby modified the milestones: 2.13.x, 2.13.0 Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants