Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: optimize old attachment query parameters using index #5363

Merged

Conversation

guqing
Copy link
Member

@guqing guqing commented Feb 18, 2024

What type of PR is this?

/kind improvement
/area core
/milestone 2.13.x

What this PR does / why we need it:

使用索引功能优化附件列表查询

Does this PR introduce a user-facing change?

使用索引功能优化附件列表查询

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 18, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.13.x milestone Feb 18, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Feb 18, 2024
@guqing guqing force-pushed the refactor/indexed-query-for-attachent branch from 8210c38 to eb21125 Compare February 18, 2024 08:38
Copy link

codecov bot commented Feb 18, 2024

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (5fdf6c0) 56.91% compared to head (ade4f4c) 56.91%.
Report is 13 commits behind head on main.

Files Patch % Lines
...ain/java/run/halo/app/infra/SchemeInitializer.java 70.83% 7 Missing ⚠️
...ension/attachment/endpoint/AttachmentEndpoint.java 79.31% 3 Missing and 3 partials ⚠️
...n/java/run/halo/app/extension/index/query/Not.java 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5363   +/-   ##
=========================================
  Coverage     56.91%   56.91%           
+ Complexity     3319     3316    -3     
=========================================
  Files           587      588    +1     
  Lines         18968    18962    -6     
  Branches       1401     1400    -1     
=========================================
- Hits          10795    10793    -2     
+ Misses         7594     7589    -5     
- Partials        579      580    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Feb 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.3% Duplication on New Code

See analysis details on SonarCloud

@guqing guqing marked this pull request as ready for review February 18, 2024 09:46
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 18, 2024
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works very well.

/lgtm

Copy link

f2c-ci-robot bot commented Feb 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 80e14e9 into halo-dev:main Feb 20, 2024
8 checks passed
@guqing guqing deleted the refactor/indexed-query-for-attachent branch February 20, 2024 03:04
@ruibaby ruibaby modified the milestones: 2.13.x, 2.13.0 Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants