Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fail to fetch correct user avatar #5369

Merged
merged 2 commits into from Feb 19, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Feb 19, 2024

What type of PR is this?

/area ui
/kind bug
/milestone 2.13.x

What this PR does / why we need it:

修复 Console 中用户头像无法正确获取的问题。

Which issue(s) this PR fixes:

Fixes #5368

Special notes for your reviewer:

测试方式:

  1. 创建若干用户,并为部分用户设置不同的头像。
  2. 分别进入不同用户的个人资料页面,观察头像是否符合预期。

Does this PR introduce a user-facing change?

修复 Console 中用户头像无法正确获取的问题。

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/ui Issues or PRs related to the Halo UI labels Feb 19, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.13.x milestone Feb 19, 2024
@f2c-ci-robot f2c-ci-robot bot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 19, 2024
@ruibaby
Copy link
Member Author

ruibaby commented Feb 19, 2024

/cherry-pick release-2.12

@halo-dev-bot
Copy link
Collaborator

@ruibaby: once the present PR merges, I will cherry-pick it on top of release-2.12 in a new PR and assign it to you.

In response to this:

/cherry-pick release-2.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@f2c-ci-robot f2c-ci-robot bot requested review from Aanko and guqing February 19, 2024 03:48
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5fdf6c0) 56.91% compared to head (1469d31) 56.90%.
Report is 10 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5369      +/-   ##
============================================
- Coverage     56.91%   56.90%   -0.01%     
+ Complexity     3319     3316       -3     
============================================
  Files           587      587              
  Lines         18968    18967       -1     
  Branches       1401     1401              
============================================
- Hits          10795    10793       -2     
- Misses         7594     7595       +1     
  Partials        579      579              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Feb 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented Feb 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2024
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 45d8391 into halo-dev:main Feb 19, 2024
8 checks passed
@halo-dev-bot
Copy link
Collaborator

@ruibaby: new pull request created: #5371

In response to this:

/cherry-pick release-2.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

f2c-ci-robot bot pushed a commit that referenced this pull request Feb 19, 2024
This is an automated cherry-pick of #5369

/assign ruibaby

```release-note
修复 Console 中用户头像无法正确获取的问题。
```
@ruibaby ruibaby modified the milestones: 2.13.x, 2.13.0 Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

用户资料的头像显示不正确
4 participants