Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide extension points for authentication-related web filters #5386

Merged

Conversation

JohnNiang
Copy link
Member

@JohnNiang JohnNiang commented Feb 21, 2024

What type of PR is this?

/kind feature
/area core
/area plugin
/milestone 2.13.x

What this PR does / why we need it:

See #5379 for more.

This PR provides three extension points:

  • FormLoginSecurityWebFilter
  • AuthenticationSecurityWebFilter
  • AnonymousAuthenticationSecurityWebFilter

which could be extended by plugins easily.

Which issue(s) this PR fixes:

Fixes #5379

Special notes for your reviewer:

TBD.

Does this PR introduce a user-facing change?

提供认证相关的 WebFilter 扩展点

@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. labels Feb 21, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.13.x milestone Feb 21, 2024
@f2c-ci-robot f2c-ci-robot bot added area/core Issues or PRs related to the Halo Core area/plugin Issues or PRs related to the Plugin Provider labels Feb 21, 2024
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: Patch coverage is 95.83333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 56.85%. Comparing base (5fdf6c0) to head (f255c3f).
Report is 20 commits behind head on main.

Files Patch % Lines
...alo/app/security/SecurityWebFiltersConfigurer.java 94.73% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5386      +/-   ##
============================================
- Coverage     56.91%   56.85%   -0.06%     
- Complexity     3319     3323       +4     
============================================
  Files           587      588       +1     
  Lines         18968    19037      +69     
  Branches       1401     1401              
============================================
+ Hits          10795    10824      +29     
- Misses         7594     7632      +38     
- Partials        579      581       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: John Niang <johnniang@foxmail.com>
@JohnNiang JohnNiang force-pushed the feat/authentication-security-web-filter branch from 80c98bb to f255c3f Compare February 23, 2024 08:12
Copy link

sonarcloud bot commented Feb 23, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues

Measures
0 Security Hotspots
No data about Coverage
0.3% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2024
Copy link

f2c-ci-robot bot commented Feb 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 23, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit bbe79ba into halo-dev:main Feb 23, 2024
8 checks passed
@JohnNiang JohnNiang deleted the feat/authentication-security-web-filter branch February 23, 2024 09:19
@ruibaby ruibaby modified the milestones: 2.13.x, 2.13.0 Feb 25, 2024
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core area/plugin Issues or PRs related to the Plugin Provider kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request to add extension points to support more security-related web filters
3 participants