New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide extension points for authentication-related web filters #5386
Provide extension points for authentication-related web filters #5386
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5386 +/- ##
============================================
- Coverage 56.91% 56.85% -0.06%
- Complexity 3319 3323 +4
============================================
Files 587 588 +1
Lines 18968 19037 +69
Branches 1401 1401
============================================
+ Hits 10795 10824 +29
- Misses 7594 7632 +38
- Partials 579 581 +2 ☔ View full report in Codecov by Sentry. |
application/src/main/java/run/halo/app/security/SecurityWebFiltersConfigurer.java
Outdated
Show resolved
Hide resolved
Signed-off-by: John Niang <johnniang@foxmail.com>
80c98bb
to
f255c3f
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
/area core
/area plugin
/milestone 2.13.x
What this PR does / why we need it:
See #5379 for more.
This PR provides three extension points:
which could be extended by plugins easily.
Which issue(s) this PR fixes:
Fixes #5379
Special notes for your reviewer:
TBD.
Does this PR introduce a user-facing change?