Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump formkit version to 1.5.x #5395

Merged
merged 5 commits into from
Feb 29, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Feb 22, 2024

What type of PR is this?

/area ui
/kind improvement
/milestone 2.13.x

What this PR does / why we need it:

升级 FormKit 的依赖版本至 1.5.x

Please see https://formkit.com/changelog#_150

Does this PR introduce a user-facing change?

升级 FormKit 的依赖版本至 1.5.x

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/ui Issues or PRs related to the Halo UI labels Feb 22, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.13.x milestone Feb 22, 2024
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Feb 22, 2024
@guqing
Copy link
Member

guqing commented Feb 22, 2024

单元测试失败了,需要修复一下

@ruibaby
Copy link
Member Author

ruibaby commented Feb 25, 2024

单元测试失败了,需要修复一下

/hold

升级之后有不少类型问题,先 hold。

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 25, 2024
ruibaby and others added 4 commits February 29, 2024 15:44
Copy link

sonarcloud bot commented Feb 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.92%. Comparing base (5fdf6c0) to head (1b3ad41).
Report is 34 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5395      +/-   ##
============================================
+ Coverage     56.91%   56.92%   +0.01%     
- Complexity     3319     3345      +26     
============================================
  Files           587      589       +2     
  Lines         18968    19145     +177     
  Branches       1401     1394       -7     
============================================
+ Hits          10795    10899     +104     
- Misses         7594     7663      +69     
- Partials        579      583       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruibaby
Copy link
Member Author

ruibaby commented Feb 29, 2024

/unhold

@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 29, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented Feb 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 29, 2024
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 29, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit f5a9889 into halo-dev:main Feb 29, 2024
8 checks passed
@ruibaby ruibaby deleted the chore/bump-formkit-1.5.x branch February 29, 2024 11:32
@JohnNiang JohnNiang modified the milestones: 2.13.x, 2.13.0 Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants