Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: optimize user query using index #5396

Merged
merged 5 commits into from Feb 27, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Feb 22, 2024

What type of PR is this?

/kind improvement
/area core
/milestone 2.13.x

What this PR does / why we need it:

使用索引机制优化用户查询以提高性能

Does this PR introduce a user-facing change?

使用索引机制优化用户查询以提高性能

@f2c-ci-robot f2c-ci-robot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/improvement Categorizes issue or PR as related to a improvement. labels Feb 22, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.13.x milestone Feb 22, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Feb 22, 2024
@ruibaby ruibaby marked this pull request as ready for review February 23, 2024 03:17
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 23, 2024
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2024
@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2024
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 56.82%. Comparing base (5fdf6c0) to head (04834b4).
Report is 27 commits behind head on main.

❗ Current head 04834b4 differs from pull request most recent head 9838d95. Consider uploading reports for the commit 9838d95 to get more accurate results

Files Patch % Lines
...alo/app/core/extension/endpoint/StatsEndpoint.java 0.00% 10 Missing ⚠️
...ain/java/run/halo/app/infra/SchemeInitializer.java 80.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5396      +/-   ##
============================================
- Coverage     56.91%   56.82%   -0.09%     
- Complexity     3319     3332      +13     
============================================
  Files           587      588       +1     
  Lines         18968    19043      +75     
  Branches       1401     1396       -5     
============================================
+ Hits          10795    10822      +27     
- Misses         7594     7640      +46     
- Partials        579      581       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Feb 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.3% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

It works very well.

Copy link

f2c-ci-robot bot commented Feb 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit a15a958 into halo-dev:main Feb 27, 2024
8 checks passed
@guqing guqing deleted the refactor/indexed-user branch February 27, 2024 08:50
@ruibaby ruibaby modified the milestones: 2.13.x, 2.13.0 Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants