New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: layout of login related page #5413
refactor: layout of login related page #5413
Conversation
Signed-off-by: Ryan Wang <i@ryanc.cc>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5413 +/- ##
============================================
- Coverage 56.91% 56.82% -0.09%
- Complexity 3319 3332 +13
============================================
Files 587 588 +1
Lines 18968 19044 +76
Branches 1401 1396 -5
============================================
+ Hits 10795 10822 +27
- Misses 7594 7641 +47
- Partials 579 581 +2 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
It works very well.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/area ui
/kind improvement
/milestone 2.13.0
What this PR does / why we need it:
优化登录相关页面的布局,修复在不同分辨率下的样式问题。
Which issue(s) this PR fixes:
Fixes #5346
Special notes for your reviewer:
测试登录或者注册页面,任意放大或者缩小页面,观察页面样式是否正常。
Does this PR introduce a user-facing change?