Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: layout of login related page #5413

Merged
merged 2 commits into from Feb 27, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Feb 27, 2024

What type of PR is this?

/area ui
/kind improvement
/milestone 2.13.0

What this PR does / why we need it:

优化登录相关页面的布局,修复在不同分辨率下的样式问题。

Which issue(s) this PR fixes:

Fixes #5346

Special notes for your reviewer:

测试登录或者注册页面,任意放大或者缩小页面,观察页面样式是否正常。

Does this PR introduce a user-facing change?

优化登录相关页面的布局,修复在不同分辨率下的样式问题。

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added area/ui Issues or PRs related to the Halo UI release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 27, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.13.0 milestone Feb 27, 2024
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Feb 27, 2024
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.82%. Comparing base (5fdf6c0) to head (cc06f45).
Report is 31 commits behind head on main.

❗ Current head cc06f45 differs from pull request most recent head 59e85e1. Consider uploading reports for the commit 59e85e1 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5413      +/-   ##
============================================
- Coverage     56.91%   56.82%   -0.09%     
- Complexity     3319     3332      +13     
============================================
  Files           587      588       +1     
  Lines         18968    19044      +76     
  Branches       1401     1396       -5     
============================================
+ Hits          10795    10822      +27     
- Misses         7594     7641      +47     
- Partials        579      581       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Feb 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

It works very well.

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2024
Copy link

f2c-ci-robot bot commented Feb 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 827030d into halo-dev:main Feb 27, 2024
8 checks passed
@ruibaby ruibaby deleted the refactor/login-page-layout branch February 27, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

优化登录/注册页面的布局
2 participants