New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: error occurs when the link is purely numerical #5479
fix: error occurs when the link is purely numerical #5479
Conversation
…-pure-digital-error
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5479 +/- ##
============================================
- Coverage 56.91% 56.86% -0.05%
- Complexity 3319 3341 +22
============================================
Files 587 589 +2
Lines 18968 19144 +176
Branches 1401 1394 -7
============================================
+ Hits 10795 10887 +92
- Misses 7594 7674 +80
- Partials 579 583 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
What type of PR is this?
/kind bug
/area editor
/area ui
/milestone 2.14.x
What this PR does / why we need it:
在默认的富文本编辑器中,使用了 tiptap link ,而其中的 renderHTML 会对 href 进行处理,但当链接为纯数字的时候,
HTMLAttributes.href
将不会有startsWith
方法。此 PR 将在解析 renderHTML 时,将
HTMLAttributes.href
转为 string,进而解决这个问题。How to test it?
测试使用默认富文本编辑器时,编写一个链接,并将其设置为纯数字。
刷新页面,查看是否具有报错。
Which issue(s) this PR fixes:
Fixes #5478
Does this PR introduce a user-facing change?