New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: missing notifier descriptors permissions in notification role template #5489
fix: missing notifier descriptors permissions in notification role template #5489
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5489 +/- ##
============================================
- Coverage 56.91% 56.81% -0.10%
- Complexity 3319 3321 +2
============================================
Files 587 589 +2
Lines 18968 19082 +114
Branches 1401 1365 -36
============================================
+ Hits 10795 10841 +46
- Misses 7594 7668 +74
+ Partials 579 573 -6 ☔ View full report in Codecov by Sentry. |
ab606b3
to
bc1019f
Compare
application/src/main/resources/extensions/role-template-notification.yaml
Dismissed
Show dismissed
Hide dismissed
bc1019f
to
cf8384a
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
/area core
/milestone 2.14.x
What this PR does / why we need it:
修复分配通知器权限时一片空白的问题
Fixes #5492
Does this PR introduce a user-facing change?