Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing notifier descriptors permissions in notification role template #5489

Merged
merged 1 commit into from Mar 15, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Mar 11, 2024

What type of PR is this?

/kind bug
/area core
/milestone 2.14.x

What this PR does / why we need it:

修复分配通知器权限时一片空白的问题

  • 隐藏了原先权限中展示的通知器配置权限选项
  • 系统设置的权限中依赖了通知器配置权限,但需要有系统设置管理权限才会展示通知配置的 Tab

Fixes #5492

Does this PR introduce a user-facing change?

修复仅拥有通知器配置权限时无法修改配置的问题

@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. labels Mar 11, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.14.x milestone Mar 11, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Mar 11, 2024
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.81%. Comparing base (5fdf6c0) to head (cf8384a).
Report is 59 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5489      +/-   ##
============================================
- Coverage     56.91%   56.81%   -0.10%     
- Complexity     3319     3321       +2     
============================================
  Files           587      589       +2     
  Lines         18968    19082     +114     
  Branches       1401     1365      -36     
============================================
+ Hits          10795    10841      +46     
- Misses         7594     7668      +74     
+ Partials        579      573       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guqing guqing force-pushed the fix/notification-role-template branch from ab606b3 to bc1019f Compare March 11, 2024 07:13
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Mar 11, 2024
@guqing guqing force-pushed the fix/notification-role-template branch from bc1019f to cf8384a Compare March 11, 2024 07:31
Copy link

sonarcloud bot commented Mar 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
No data about Coverage
0.2% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2024
Copy link

f2c-ci-robot bot commented Mar 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 26dc24c into halo-dev:main Mar 15, 2024
9 checks passed
@guqing guqing deleted the fix/notification-role-template branch March 15, 2024 16:07
@ruibaby ruibaby modified the milestones: 2.14.x, 2.14.0 Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

分配通知器配置权限但没有系统设置权限后无法配置
3 participants