Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pref: optimize the help style of some formkit components #5521

Merged
merged 3 commits into from Mar 25, 2024

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Mar 18, 2024

What type of PR is this?

/kind improvement
/area ui

What this PR does / why we need it:

优化 formkit 中 checkout、repeater、group 组件的 help 样式。

移除 checkout 的内边距
为 repeater、group 组件增加底部边距

How to test it?

观察上述组件的 help 样式是否正常。

Which issue(s) this PR fixes:

Fixes #5411

Does this PR introduce a user-facing change?

优化表单中复选框、单选框等组件的帮助文字样式。

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/improvement Categorizes issue or PR as related to a improvement. labels Mar 18, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/ui Issues or PRs related to the Halo UI label Mar 18, 2024
@LIlGG LIlGG added this to the 2.14.x milestone Mar 18, 2024
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.56%. Comparing base (5fdf6c0) to head (72d434d).
Report is 77 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5521      +/-   ##
============================================
- Coverage     56.91%   56.56%   -0.35%     
+ Complexity     3319     3310       -9     
============================================
  Files           587      592       +5     
  Lines         18968    19178     +210     
  Branches       1401     1355      -46     
============================================
+ Hits          10795    10848      +53     
- Misses         7594     7769     +175     
+ Partials        579      561      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruibaby
Copy link
Member

ruibaby commented Mar 20, 2024

在 Repeater 或者 Group 中的 Checkbox 和 Radio 等组件似乎没有对齐。

image

Copy link

sonarcloud bot commented Mar 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.4% Duplication on New Code

See analysis details on SonarCloud

@LIlGG
Copy link
Member Author

LIlGG commented Mar 21, 2024

在 Repeater 或者 Group 中的 Checkbox 和 Radio 等组件似乎没有对齐。

经过测试,radio 组件正常。已补充 checkbox 的样式。

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2024
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented Mar 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 499b9ea into halo-dev:main Mar 25, 2024
8 checks passed
@ruibaby ruibaby modified the milestones: 2.14.x, 2.14.0 Mar 25, 2024
@LIlGG LIlGG deleted the pref/formkit-help-style branch March 27, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FormKit 的 checkbox 组件的 help 文字样式问题。
4 participants