Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: selecting the previous post leads to a negative page #5594

Merged
merged 1 commit into from Mar 26, 2024

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Mar 26, 2024

What type of PR is this?

/kind bug
/area ui

What this PR does / why we need it:

修复当选中首个文章设置时,点击上一个还可以继续修改 page 的问题。

How to test it?

测试选中首个文章设置之后,点击上一个是否不再修改 page

Which issue(s) this PR fixes:

Fixes #5475

Does this PR introduce a user-facing change?

修复在文章列表设置中可以无限点击上一个的问题

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. area/ui Issues or PRs related to the Halo UI labels Mar 26, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from Aanko and QuentinHsu March 26, 2024 08:00
@LIlGG LIlGG added this to the 2.14.x milestone Mar 26, 2024
Copy link

sonarcloud bot commented Mar 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.4% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch man

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2024
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.49%. Comparing base (5fdf6c0) to head (b7daef9).
Report is 82 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5594      +/-   ##
============================================
- Coverage     56.91%   56.49%   -0.43%     
- Complexity     3319     3320       +1     
============================================
  Files           587      595       +8     
  Lines         18968    19249     +281     
  Branches       1401     1357      -44     
============================================
+ Hits          10795    10874      +79     
- Misses         7594     7813     +219     
+ Partials        579      562      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LIlGG LIlGG changed the title fix: selecting the previous article leads to a negative page fix: selecting the previous post leads to a negative page Mar 26, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

f2c-ci-robot bot commented Mar 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 1fb4c82 into halo-dev:main Mar 26, 2024
8 checks passed
@LIlGG LIlGG deleted the fix/post-select-previous branch March 26, 2024 09:15
@ruibaby ruibaby modified the milestones: 2.14.x, 2.14.0 Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

在文章列表点击设置后,可以无限点击前一个文章设置
4 participants