Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unable to modify the publish time of post in the uc #5596

Merged
merged 1 commit into from Mar 26, 2024

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Mar 26, 2024

What type of PR is this?

/kind bug
/area core

What this PR does / why we need it:

修复在个人中心下,用户无法修改发布时间的问题。

How to test it?

需要测试两种情况:

  1. 用户首次发布文章时,修改发布时间是否有效。
  2. 用户后续编辑文章发布时间时是否生效。

Which issue(s) this PR fixes:

Fixes #5473

Does this PR introduce a user-facing change?

修复个人中心中用户无法修改文章发布时间的问题

@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. area/core Issues or PRs related to the Halo Core labels Mar 26, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and minliacom March 26, 2024 09:03
@LIlGG
Copy link
Member Author

LIlGG commented Mar 26, 2024

/milestone 2.14.x

@f2c-ci-robot f2c-ci-robot bot added this to the 2.14.x milestone Mar 26, 2024
Copy link

sonarcloud bot commented Mar 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.3% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2024
Copy link

f2c-ci-robot bot commented Mar 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2024
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.49%. Comparing base (5fdf6c0) to head (8b5fb7c).
Report is 83 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5596      +/-   ##
============================================
- Coverage     56.91%   56.49%   -0.42%     
- Complexity     3319     3320       +1     
============================================
  Files           587      595       +8     
  Lines         18968    19248     +280     
  Branches       1401     1357      -44     
============================================
+ Hits          10795    10874      +79     
- Misses         7594     7812     +218     
+ Partials        579      562      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@f2c-ci-robot f2c-ci-robot bot merged commit b660eb6 into halo-dev:main Mar 26, 2024
8 checks passed
@ruibaby ruibaby modified the milestones: 2.14.x, 2.14.0 Mar 26, 2024
@LIlGG LIlGG deleted the fix/uc-publish-time branch March 27, 2024 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

个人中心文章无法自定义发布时间
3 participants