refactor: simplify the dialogs title #5601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Wang <i@ryanc.cc>
f2c-ci-robot
bot
added
release-note
f2c-ci-robot
bot
added
the
kind/improvement
ruibaby
changed the title
f2c-ci-robot
bot
added
the
do-not-merge/work-in-progress
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5601 +/- ##
============================================
- Coverage 56.91% 56.49% -0.42%
- Complexity 3319 3320 +1
============================================
Files 587 595 +8
Lines 18968 19248 +280
Branches 1401 1357 -44
============================================
+ Hits 10795 10874 +79
- Misses 7594 7812 +218
+ Partials 579 562 -17 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Ryan Wang <i@ryanc.cc>
ruibaby
changed the title
f2c-ci-robot
bot
removed
the
do-not-merge/work-in-progress
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/area ui
/kind improvement
/milestone 2.14.x
What this PR does / why we need it:
简化部分确认框的标题。
Which issue(s) this PR fixes:
Fixes #5592
Does this PR introduce a user-facing change?