Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changes to Unstructured metadata do not take effect #5880

Merged
merged 1 commit into from May 10, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented May 10, 2024

What type of PR is this?

/kind bug
/area core
/milestone 2.16.x

What this PR does / why we need it:

修复对 Unstructured 的 metadata 进行更改不会被应用的问题

Does this PR introduce a user-facing change?

修复插件定义的权限没有在插件详情页显示的问题

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels May 10, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.16.x milestone May 10, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from JohnNiang May 10, 2024 03:58
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label May 10, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from ruibaby May 10, 2024 03:58
Copy link

sonarcloud bot commented May 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.2% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 56.41%. Comparing base (5fdf6c0) to head (09800a2).
Report is 160 commits behind head on main.

Files Patch % Lines
...main/java/run/halo/app/extension/Unstructured.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5880      +/-   ##
============================================
- Coverage     56.91%   56.41%   -0.50%     
- Complexity     3319     3449     +130     
============================================
  Files           587      612      +25     
  Lines         18968    20438    +1470     
  Branches       1401     1411      +10     
============================================
+ Hits          10795    11531     +736     
- Misses         7594     8329     +735     
+ Partials        579      578       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2024
@JohnNiang
Copy link
Member

/cherrypick release-2.15

@halo-dev-bot
Copy link
Collaborator

@JohnNiang: once the present PR merges, I will cherry-pick it on top of release-2.15 in a new PR and assign it to you.

In response to this:

/cherrypick release-2.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2024
Copy link

f2c-ci-robot bot commented May 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit dc451e2 into halo-dev:main May 10, 2024
8 checks passed
@halo-dev-bot
Copy link
Collaborator

@JohnNiang: new pull request created: #5881

In response to this:

/cherrypick release-2.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

f2c-ci-robot bot pushed a commit that referenced this pull request May 10, 2024
…ct (#5881)

This is an automated cherry-pick of #5880

/assign JohnNiang

```release-note
修复插件定义的权限没有在插件详情页显示的问题
```
@ruibaby ruibaby modified the milestones: 2.16.x, 2.16.0 May 16, 2024
@guqing guqing deleted the fix/unstructured-metadata branch May 23, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants