Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: secret data cannot be used in YAML #5917

Merged
merged 1 commit into from
May 15, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented May 15, 2024

What type of PR is this?

/kind bug
/area core
/milestone 2.16.x

What this PR does / why we need it:

修复 Secret 的 data 字段无法在 YAML 使用的问题

Does this PR introduce a user-facing change?

None

@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. labels May 15, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.16.x milestone May 15, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and LIlGG May 15, 2024 07:01
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label May 15, 2024
Copy link

sonarcloud bot commented May 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.2% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.60%. Comparing base (5fdf6c0) to head (7368f87).
Report is 166 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5917      +/-   ##
============================================
- Coverage     56.91%   56.60%   -0.32%     
- Complexity     3319     3466     +147     
============================================
  Files           587      612      +25     
  Lines         18968    20477    +1509     
  Branches       1401     1413      +12     
============================================
+ Hits          10795    11590     +795     
- Misses         7594     8306     +712     
- Partials        579      581       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2024
Copy link

f2c-ci-robot bot commented May 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 983e70d into halo-dev:main May 15, 2024
7 checks passed
@guqing guqing deleted the fix/secret branch May 15, 2024 15:35
@ruibaby ruibaby modified the milestones: 2.16.x, 2.16.0 May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants