Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: original should be removed when session id changed #5931

Merged
merged 1 commit into from
May 16, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented May 16, 2024

What type of PR is this?

/kind improvement
/area core

What this PR does / why we need it:

当 session id 改变时清除原来的 session id 记录

Does this PR introduce a user-facing change?

None

@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. kind/improvement Categorizes issue or PR as related to a improvement. labels May 16, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from LIlGG May 16, 2024 07:56
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label May 16, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from ruibaby May 16, 2024 07:56
Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 56.61%. Comparing base (5fdf6c0) to head (958a9fc).
Report is 172 commits behind head on main.

Files Patch % Lines
...sion/InMemoryReactiveIndexedSessionRepository.java 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5931      +/-   ##
============================================
- Coverage     56.91%   56.61%   -0.31%     
- Complexity     3319     3468     +149     
============================================
  Files           587      612      +25     
  Lines         18968    20528    +1560     
  Branches       1401     1419      +18     
============================================
+ Hits          10795    11621     +826     
- Misses         7594     8323     +729     
- Partials        579      584       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.2% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2024
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label May 16, 2024
Copy link

f2c-ci-robot bot commented May 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 9c98d0a into halo-dev:main May 16, 2024
8 checks passed
@guqing guqing deleted the refactor/session branch May 16, 2024 09:15
@ruibaby ruibaby added this to the 2.16.0 milestone May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants