Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add default sort for extension listing #5937

Merged
merged 2 commits into from
May 20, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented May 17, 2024

What type of PR is this?

/kind improvement
/area core
/milestone 2.16.x

What this PR does / why we need it:

为自定义模型 List API 添加默认排序

Which issue(s) this PR fixes:

Fixes #5647

Does this PR introduce a user-facing change?

为自定义模型 List API 添加默认排序

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/improvement Categorizes issue or PR as related to a improvement. labels May 17, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.16.x milestone May 17, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from JohnNiang May 17, 2024 03:36
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label May 17, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from ruibaby May 17, 2024 03:36
Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 56.55%. Comparing base (5fdf6c0) to head (e2d8485).
Report is 177 commits behind head on main.

Files Patch % Lines
...run/halo/app/extension/router/SortableRequest.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5937      +/-   ##
============================================
- Coverage     56.91%   56.55%   -0.36%     
- Complexity     3319     3468     +149     
============================================
  Files           587      612      +25     
  Lines         18968    20548    +1580     
  Branches       1401     1420      +19     
============================================
+ Hits          10795    11621     +826     
- Misses         7594     8343     +749     
- Partials        579      584       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2024
@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label May 20, 2024
@guqing guqing requested a review from JohnNiang May 20, 2024 08:21
Copy link

sonarcloud bot commented May 20, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.2% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2024
Copy link

f2c-ci-robot bot commented May 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 2a7900c into halo-dev:main May 20, 2024
8 checks passed
@guqing guqing deleted the refactor/5647 branch May 20, 2024 08:49
@ruibaby ruibaby modified the milestones: 2.16.x, 2.16.0 May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

增强备份和站点收录推送的日志都是不按时间排序的
3 participants