Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: color style issue of code block in post content snapshot page #5982

Merged
merged 1 commit into from
May 24, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented May 24, 2024

What type of PR is this?

/area ui
/kind bug
/milestone 2.16.x

What this PR does / why we need it:

修复在文章版本历史内容预览中代码块颜色显示异常的问题。

Which issue(s) this PR fixes:

Fixes #5845

Does this PR introduce a user-facing change?

修复在文章版本历史内容预览中代码块颜色显示异常的问题。

@f2c-ci-robot f2c-ci-robot bot added area/ui Issues or PRs related to the Halo UI release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 24, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.16.x milestone May 24, 2024
@f2c-ci-robot f2c-ci-robot bot added the kind/bug Categorizes issue or PR as related to a bug. label May 24, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and wan92hen May 24, 2024 04:37
Copy link

sonarcloud bot commented May 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label May 24, 2024
Copy link

f2c-ci-robot bot commented May 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2024
Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.68%. Comparing base (5fdf6c0) to head (607646d).
Report is 200 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5982      +/-   ##
============================================
- Coverage     56.91%   56.68%   -0.23%     
- Complexity     3319     3475     +156     
============================================
  Files           587      609      +22     
  Lines         18968    20478    +1510     
  Branches       1401     1418      +17     
============================================
+ Hits          10795    11608     +813     
- Misses         7594     8292     +698     
+ Partials        579      578       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@f2c-ci-robot f2c-ci-robot bot merged commit 69c3a63 into halo-dev:main May 24, 2024
8 checks passed
@ruibaby ruibaby deleted the fix/code-color-style branch May 24, 2024 05:47
@JohnNiang JohnNiang modified the milestones: 2.16.x, 2.16.0 May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

文章/页面历史版本代码框字体颜色看不清
2 participants