Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add default implementation for comment widget #1

Merged
merged 2 commits into from
Sep 30, 2022
Merged

feat: add default implementation for comment widget #1

merged 2 commits into from
Sep 30, 2022

Conversation

guqing
Copy link
Member

@guqing guqing commented Sep 28, 2022 •
edited
Loading

What this PR does?

新增评论组件实现

how to test it?

使用一个主题并在文章页面的任何位置添加

<halo:comment group="content.halo.run" kind="Post" th:name=${post.metadata.name}"/>

使用此插件后到文章也查看是否有评论组件

/kind feature
/cc @halo-sigs/halo

None

@f2c-ci-robot f2c-ci-robot bot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 28, 2022
ruibaby
ruibaby reviewed Sep 30, 2022
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2022
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Sep 30, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ruibaby ruibaby merged commit 2d1aacf into main Sep 30, 2022
@ruibaby ruibaby deleted the feature/comment branch September 30, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruibaby ruibaby ruibaby left review comments

Assignees

@ruibaby ruibaby

Labels
kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@guqing @ruibaby