Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pref: Use base-info-color variable to unify non important prominent text #89

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

AirboZH
Copy link
Member

@AirboZH AirboZH commented Mar 5, 2024

增加变量以适配主题颜色

Resolve #88

Copy link

f2c-ci-robot bot commented Mar 5, 2024

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
Copy link

f2c-ci-robot bot commented Mar 5, 2024

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@f2c-ci-robot f2c-ci-robot bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 5, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and ruibaby March 5, 2024 15:44
@ruibaby
Copy link
Member

ruibaby commented Mar 6, 2024

我们是否可以直接新建一个统一的变量,命名为 base-info-color 或者 base-accent-color,用于为非重要突出的文字统一设置颜色。

@AirboZH
Copy link
Member Author

AirboZH commented Mar 6, 2024

我们是否可以直接新建一个统一的变量,命名为 base-info-color 或者 base-accent-color,用于为非重要突出的文字统一设置颜色。

没问题!除了这个 meta-info 还有什么字段是 非重要突出文字 呢

@ruibaby
Copy link
Member

ruibaby commented Mar 6, 2024

我们是否可以直接新建一个统一的变量,命名为 base-info-color 或者 base-accent-color,用于为非重要突出的文字统一设置颜色。

没问题!除了这个 meta-info 还有什么字段是 非重要突出文字 呢

比如列表项中的点赞、回复按钮的图标和文字默认颜色,改为 base-info-color 变量之后,hover 的时候可以设置为 base-color。

image

还有 Emoji 图标同上。

image

@AirboZH
Copy link
Member Author

AirboZH commented Mar 6, 2024

我认为列表项中的点赞、回复按钮的图标和文字默认颜色可以设置为 base-info-color 但是 Emoji 图标还是和左侧用户名颜色对齐可能更好些。

image
image

@ruibaby
Copy link
Member

ruibaby commented Mar 6, 2024

@AirboZH Okay

@AirboZH AirboZH changed the title pref: add --component-comment-item-meta-info-color var pref: Use base-info-color variable to unify non important prominent text Mar 7, 2024
@AirboZH
Copy link
Member Author

AirboZH commented Mar 7, 2024

ping @ruibaby

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

感谢 @AirboZH 的贡献。

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2024
Copy link

f2c-ci-robot bot commented Mar 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 2360cf2 into halo-dev:main Mar 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

增加 comment-item-meta-info 颜色变量支持
2 participants