Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix url space error #41

Merged
merged 3 commits into from
Jun 1, 2023
Merged

Fix url space error #41

merged 3 commits into from
Jun 1, 2023

Conversation

longjuan
Copy link
Member

@longjuan longjuan commented May 17, 2023 •
edited

Fixes #40
image

None

@f2c-ci-robot f2c-ci-robot bot added the release-note-none Denotes a PR that doesn't merit a release note. label May 17, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and JohnNiang May 17, 2023 05:58
guqing
guqing reviewed May 17, 2023
View reviewed changes
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
经测试 111F32F1B9D-中文 %sasdas d123.jpeg 文件名称是可以的

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2023
@longjuan
Copy link
Member Author

longjuan commented Jun 1, 2023

/cc @halo-sigs/halo

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jun 1, 2023

@longjuan: GitHub didn't allow me to request PR reviews from the following users: halo-sigs/halo.

Note that only halo-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @halo-sigs/halo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ruibaby
ruibaby approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2023
@longjuan
Merge remote-tracking branch 'upstream/main' into fix/URL_space_error
64ec040 
# Conflicts:
#	src/main/java/run/halo/s3os/S3OsAttachmentHandler.java
@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 1, 2023
ruibaby
ruibaby approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 1, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jun 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 022ecea into halo-dev:main Jun 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guqing guqing guqing left review comments

@ruibaby ruibaby ruibaby approved these changes

@JohnNiang JohnNiang Awaiting requested review from JohnNiang

Assignees

@ruibaby ruibaby

@guqing guqing

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

上传带空格文件名的文件会导致生成permalink失败
3 participants
@longjuan @ruibaby @guqing