Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Associate files originally in s3 #59

Merged
merged 11 commits into from Sep 11, 2023
Merged

feat: Associate files originally in s3 #59

merged 11 commits into from Sep 11, 2023

Conversation

longjuan
Copy link
Member

@longjuan longjuan commented Aug 6, 2023 •
edited 

关联从其他渠道上传至 s3 的文件

【插件】->【对象存储（Amazon S3 协议）】->【关联s3文件】
image
image

目前待优化的功能：

  • 列出未关联的文件时会查询多次数据库，期望优化成只查询一次，但是代码改动较大。

@f2c-ci-robot f2c-ci-robot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 6, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from ruibaby and wan92hen August 6, 2023 03:32
ruibaby
ruibaby requested changes Aug 6, 2023
View reviewed changes
console/src/components/AttachmentFileTypeIcon.vue Outdated Show resolved Hide resolved
console/src/components/filter/FilterCleanButton.vue Outdated Show resolved Hide resolved
console/src/components/filter/FilterTag.vue Outdated Show resolved Hide resolved
@longjuan longjuan mentioned this pull request Aug 12, 2023
Closed
@longjuan longjuan changed the title WIP: migrate s3link features feat: Associate files originally in s3 Sep 4, 2023
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 4, 2023
@longjuan
Copy link
Member Author

longjuan commented Sep 4, 2023 •
edited

目前待优化的功能：

  • 列出未关联的文件时会查询多次数据库，期望优化成只查询一次，但是代码改动较大。
  • 关联文件时没有查询是否已在附件库（防止多次操作），需要改动成对于一整个关联请求查询一次数据库。

/ping @halo-sigs/halo 看这两个优化点可不可以后面再做，反正现在能用。

@JohnNiang
Copy link
Member

/ping @halo-sigs/halo

@longjuan
Copy link
Member Author

longjuan commented Sep 7, 2023

image
已实现双标签页操作也不会重复关联

@ruibaby
Copy link
Member

ruibaby commented Sep 7, 2023

我觉得 OK。

cc @halo-sigs/halo

@ruibaby
Copy link
Member

ruibaby commented Sep 7, 2023

image

Wow~

JohnNiang
JohnNiang reviewed Sep 11, 2023
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2023
ruibaby
ruibaby approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Sep 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 91a61fd into halo-dev:main Sep 11, 2023
1 check passed
@longjuan longjuan deleted the feat/s3link branch March 1, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnNiang JohnNiang JohnNiang left review comments

@ruibaby ruibaby ruibaby approved these changes

@wan92hen wan92hen Awaiting requested review from wan92hen

Assignees

@JohnNiang JohnNiang

@ruibaby ruibaby

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@longjuan @JohnNiang @ruibaby