Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Optimize access_key description #71

Merged
merged 1 commit into from Sep 18, 2023
Merged

chore: Optimize access_key description #71

merged 1 commit into from Sep 18, 2023

Conversation

AccAutomaton
Copy link
Contributor

@AccAutomaton AccAutomaton commented Sep 18, 2023 •
edited by JohnNiang

Fixes #67

优化`Access Key`相关的描述，减少误解

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Sep 18, 2023
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 18, 2023
JohnNiang
JohnNiang approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Sep 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2023
longjuan
longjuan reviewed Sep 18, 2023
View reviewed changes
Copy link
Member

@longjuan longjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit e204802 into halo-dev:main Sep 18, 2023
1 check passed
@AccAutomaton AccAutomaton deleted the optimize_access_key_description branch September 19, 2023 04:25
@AccAutomaton AccAutomaton mentioned this pull request Sep 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@longjuan longjuan longjuan left review comments

@JohnNiang JohnNiang JohnNiang approved these changes

@guqing guqing Awaiting requested review from guqing

Assignees

@longjuan longjuan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

使用腾讯云oss时候遇到的问题，秘钥和秘钥id写反了
3 participants
@AccAutomaton @JohnNiang @longjuan