Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add URL suffix to files of specified type #79

Merged
merged 2 commits into from Oct 26, 2023

Conversation

longjuan
Copy link
Member

@longjuan longjuan commented Sep 27, 2023

增加网址后缀功能
image

此功能在文件上传和关联文件均生效

Fix #77
Fix #68

增加给指定类型的文件加上特定的网址后缀功能

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 27, 2023
@JohnNiang
Copy link
Member

我这里针对图片附件有几点疑惑:

  1. 是否每张图片都需要经过相同的样式或者处理
  2. 能否对单个图片进行单独设置后缀

@Country1674
Copy link

增加网址后缀功能 image

此功能在文件上传和关联文件均生效

Fix #77 Fix #68

增加给指定类型的文件加上特定的网址后缀功能

大佬,这个啥时候才能合并出包呀

@longjuan
Copy link
Member Author

  1. 是否每张图片都需要经过相同的样式或者处理

对于转webp这种格式转换的处理几乎都要进行处理,或者加一个超过指定大小才加后缀?

2. 能否对单个图片进行单独设置后缀

是说在上传后进行设置还是上传前进行后缀配置?

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @longjuan ,关于第二点:对于已上传的附件进行后缀配置。

不过当前我们可以考虑先合并,根据用户的反馈再优化也可以。

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Oct 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/kind feature

@f2c-ci-robot f2c-ci-robot bot added kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. labels Oct 26, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 08d6ff4 into halo-dev:main Oct 26, 2023
1 check passed
@longjuan longjuan deleted the feat/url-suffix branch March 1, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
3 participants