Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extract more CSS variables #25

Merged
merged 5 commits into from Feb 20, 2024
Merged

Conversation

jiewenhuang
Copy link
Contributor

@jiewenhuang jiewenhuang commented Feb 19, 2024

为了更好的适配主题样式,新增以下CSS变量:

--halo-search-widget-font-size-search-form-input:;                     /*输入框字体大小*/
--halo-search-widget-line-height-search-form-input:;                   /*输入框行高*/
--halo-search-widget-font-size-search-form-result-item-title:;         /*搜索结果项标题字体大小*/
--halo-search-widget-line-height-search-form-result-item-title:;       /*搜索结果项标题行高*/
--halo-search-widget-font-size-search-form-result-item-content:;       /*搜索结果项内容字体大小*/
--halo-search-widget-line-height-search-form-result-item-content:;     /*搜索结果项内容行高*/
--halo-search-widget-font-size-search-form-empty:;                     /*搜索结果为空时的字体大小*/
--halo-search-widget-line-height-search-form-empty:;                   /*搜索结果为空时的行高*/
--halo-search-widget-font-size-search-form-commands-item:;             /*搜索框底部快捷键提示字体大小*/
--halo-search-widget-line-height-search-commands-item:;                /*搜索框底部快捷键提示行高*/
--halo-search-widget-font-size-search-form-commands-item-kbd:;         /*搜索框底部快捷键提示图标大小*/ 
--halo-search-widget-min-width-search-commands-item-kbd:;              /*搜索框底部快捷键提示图标 min-wight*/
--halo-search-widget-font-family-search-form:;                         /*搜索框字体*/
新增 CSS 变量以更好地适配主题样式

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Feb 19, 2024
@JohnNiang
Copy link
Member

/ping @halo-dev/sig-halo-console

@ruibaby ruibaby changed the title add:extract more CSS variables feat: extract more CSS variables Feb 20, 2024
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 20, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented Feb 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 5b90f5d into halo-dev:main Feb 20, 2024
1 check passed
@ruibaby ruibaby mentioned this pull request Mar 5, 2024
f2c-ci-robot bot pushed a commit that referenced this pull request Mar 5, 2024
移除在 #25 中提供的字体和行高变量,改为和 halo-dev/plugin-comment-widget#80 中一致的字体设置方案。

添加了三个 CSS 变量:

```
--halo-search-widget-base-font-size: ;			全局字体大小
--halo-search-widget-base-border-radius: ;	边框圆角
--halo-search-widget-base-font-family: ;			字体
```

/kind feature

```release-note
添加和字体相关的 CSS 变量
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants