Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: editor katext extension #3

Merged
merged 4 commits into from
Jul 8, 2023
Merged

Conversation

xinkeng0
Copy link
Member

@xinkeng0 xinkeng0 commented Jul 6, 2023

The katex extension for richtext-editor is coming. 馃巼
Consistent editing experience with the richtext-editor.

There are currently some known minor issues.

  • The bubble menu should not appear when clicking on a formula.
  • The style of the formula component is not attractive enough.
  • Internationalization support.
  • Block-katex paste support.(Now always taken over by inline-paste-Regex.)

Anyway, it's time to experience the formula plugin!

2023-07-06.205053.mp4
Add KaTex supports for Editor

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jul 6, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and JohnNiang July 6, 2023 12:59
@xinkeng0
Copy link
Member Author

xinkeng0 commented Jul 6, 2023

whether to merge or not requires everyone's vote.

@xinkeng0 xinkeng0 linked an issue Jul 6, 2023 that may be closed by this pull request
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 7, 2023
@ruibaby ruibaby requested a review from wan92hen July 7, 2023 03:28
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

image

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2023
@ruibaby
Copy link
Member

ruibaby commented Jul 7, 2023

@halo-sigs/halo cc

console/package.json Outdated Show resolved Hide resolved
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jul 7, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from ruibaby after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jul 7, 2023

New changes are detected. LGTM label has been removed.

Co-authored-by: Takagi <mail@e.lixingyong.com>
@xinkeng0 xinkeng0 merged commit 1341e43 into halo-sigs:main Jul 8, 2023
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add KaTex supports for Editor
3 participants