Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make logo form item type to attachment #41

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Aug 1, 2023

修改链接表单的 Logo 输入框类型为 attachment,用于从附件库选择图片。

/kind improvement

Ref #39 (comment)

修改链接表单的 Logo 输入框类型为 `attachment`,用于从附件库选择图片。

@ruibaby ruibaby mentioned this pull request Aug 1, 2023
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/improvement Categorizes issue or PR as related to a improvement. labels Aug 1, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and JohnNiang August 1, 2023 10:13
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2023
Copy link
Collaborator

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Aug 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit e91fba7 into halo-sigs:main Aug 3, 2023
4 checks passed
@ruibaby ruibaby deleted the feat/logo-form-type branch August 6, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants