Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor import strategy to support multiple providers #26

Merged
merged 23 commits into from
Aug 22, 2023
Merged

Refactor import strategy to support multiple providers #26

merged 23 commits into from
Aug 22, 2023

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Aug 9, 2023 •
edited

重构导入策略，支持多 provider

可供测试的 jar 包。

plugin-migrate-1.2.0-SNAPSHOT.jar.zip

Fixes #2

重构导入策略，支持多 provider

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 9, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and ruibaby August 9, 2023 09:44
@LIlGG LIlGG changed the title refactor: refactor import strategy to support multiple providers WIP:refactor: refactor import strategy to support multiple providers Aug 9, 2023
@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 9, 2023
@ruibaby
Refine ui
5fa8e40 
Signed-off-by: Ryan Wang <i@ryanc.cc>
@ruibaby ruibaby changed the title WIP:refactor: refactor import strategy to support multiple providers WIP: Refactor import strategy to support multiple providers Aug 10, 2023
@ruibaby
Copy link
Member

ruibaby commented Aug 12, 2023

@LIlGG Ready for review?

@JohnNiang JohnNiang changed the title WIP: Refactor import strategy to support multiple providers Refactor import strategy to support multiple providers Aug 14, 2023
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 14, 2023
@JohnNiang JohnNiang added kind/feature Categorizes issue or PR as related to a new feature. kind/improvement Categorizes issue or PR as related to a improvement. labels Aug 14, 2023
@LIlGG
Copy link
Member Author

LIlGG commented Aug 16, 2023

@LIlGG Ready for review?

插件功能基本完成，可以开始 review 了。

ruibaby
ruibaby requested changes Aug 22, 2023
View reviewed changes
console/src/components/AttachmentPolicy.vue Outdated Show resolved Hide resolved
console/src/components/AttachmentPolicy.vue Outdated Show resolved Hide resolved
console/src/components/AttachmentPolicy.vue Show resolved Hide resolved
console/src/components/FileSelector.vue Show resolved Hide resolved
console/src/modules/atom/AtomMigrateDataParser.vue Outdated Show resolved Hide resolved
console/src/modules/wordpress/WordPressMigrateDataParser.vue Outdated Show resolved Hide resolved
console/src/types/index.ts Outdated Show resolved Hide resolved
docs/.vitepress/config.ts Outdated Show resolved Hide resolved
docs/.vitepress/config.ts Outdated Show resolved Hide resolved
console/src/index.ts Outdated Show resolved Hide resolved
@LIlGG LIlGG requested a review from ruibaby August 22, 2023 09:21
ruibaby
ruibaby reviewed Aug 22, 2023
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2023
@ruibaby
Copy link
Member

ruibaby commented Aug 22, 2023

cc @halo-sigs/halo

JohnNiang
JohnNiang approved these changes Aug 22, 2023
View reviewed changes
Copy link

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Aug 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit c014013 into halo-sigs:main Aug 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruibaby ruibaby ruibaby requested changes

@JohnNiang JohnNiang JohnNiang approved these changes

@guqing guqing Awaiting requested review from guqing

Assignees

@JohnNiang JohnNiang

@ruibaby ruibaby

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

重构此插件的导入策略，支持多个 Provider
3 participants
@LIlGG @ruibaby @JohnNiang