Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inability to import RSS articles due to additional attributes #34

Merged
merged 10 commits into from
Jan 8, 2024

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Jan 8, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

将 rss 解析 xml 时的 ignoreAttributes 属性设置为 true。用于避免可能出现的由于额外属性而导致导入失败的问题。

How to test it?

使用具有额外属性的 RSS,例如 <content:encoded xml:lang="zh-CN"> 等进行导入,查看导入是否成功。

Which issue(s) this PR fixes:

Fixes #32

Does this PR introduce a user-facing change?

解决由于额外属性所导致的导入失败的问题。

@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jan 8, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and ruibaby January 8, 2024 02:53
Copy link

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2024
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2024
Copy link

f2c-ci-robot bot commented Jan 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 3009f24 into halo-sigs:main Jan 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

【BUG】关于description标签和content:encoded标签的识别问题
3 participants