Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add an API for moment detail #80

Merged
merged 3 commits into from
Feb 21, 2024

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Feb 20, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

提供获取单条瞬间详细信息的接口,此接口返回数据包括瞬间作者信息及点赞数、评论数等。

How to test it?

测试接口 /apis/console.api.moment.halo.run/v1alpha1/moments/{name} 是否可用。

Which issue(s) this PR fixes:

Fixes #74

Does this PR introduce a user-facing change?

提供获取单条瞬间详细信息的接口

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Feb 20, 2024
@LIlGG
Copy link
Member Author

LIlGG commented Feb 21, 2024

/hold 等待 #81 合并之后,需要对接口进行修改

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 21, 2024
@LIlGG
Copy link
Member Author

LIlGG commented Feb 21, 2024

/kind api-change

@f2c-ci-robot f2c-ci-robot bot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Feb 21, 2024
@LIlGG
Copy link
Member Author

LIlGG commented Feb 21, 2024

/unhold

@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 21, 2024
@guqing
Copy link
Member

guqing commented Feb 21, 2024

修改一下 PR 描述,与实际内容不符

@LIlGG
Copy link
Member Author

LIlGG commented Feb 21, 2024

修改一下 PR 描述,与实际内容不符

已修改

@guqing guqing changed the title feat: add interface to get instant details feat: add an API for moment detail Feb 21, 2024
@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2024
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2024
Copy link

f2c-ci-robot bot commented Feb 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit e41c389 into halo-sigs:main Feb 21, 2024
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

提供获取单个瞬间详情的接口
3 participants