Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: user connections was not completely deleted when unbinding #9

Merged
merged 2 commits into from
Mar 31, 2023
Merged

fix: user connections was not completely deleted when unbinding #9

merged 2 commits into from
Mar 31, 2023

Conversation

guqing
Copy link
Member

@guqing guqing commented Mar 30, 2023 •
edited

What this PR does?

修复用户解绑时 UserConnection 数据没有完全删除的问题

how to test it?
绑定账号并解绑查看关联的 userconnections 是否被删除

curl -u 'your-username:your-password' http://127.0.0.1:8090/apis/auth.halo.run/v1alpha1/userconnections | jq  -r '.'

Fixes #8

修复用户解绑时 UserConnection 数据没有被完全删除的问题

@f2c-ci-robot f2c-ci-robot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Mar 30, 2023
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Mar 30, 2023
ruibaby
ruibaby approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2023
JohnNiang
JohnNiang approved these changes Mar 31, 2023
View reviewed changes
Copy link

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2023
@guqing
Merge remote-tracking branch 'upstream/main' into refactor/unbinding
c063ae9 
# Conflicts:
#	src/main/java/run/halo/oauth/UserConnectionService.java
#	src/main/java/run/halo/oauth/UserConnectionServiceImpl.java
@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2023
JohnNiang
JohnNiang approved these changes Mar 31, 2023
View reviewed changes
Copy link

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Mar 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 3329fc2 into halo-sigs:main Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnNiang JohnNiang JohnNiang approved these changes

@ruibaby ruibaby ruibaby approved these changes

Assignees

@JohnNiang JohnNiang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

用户解绑时 UserConnection 数据没有完全删除
3 participants
@guqing @JohnNiang @ruibaby