Skip to content
This repository has been archived by the owner on Nov 29, 2023. It is now read-only.

feat: add an indentation extension to the editor #34

Merged
merged 2 commits into from Aug 25, 2023

Conversation

LIlGG
Copy link
Contributor

@LIlGG LIlGG commented Aug 24, 2023

What type of PR is this?

/kind feature
/aear editor

What this PR does / why we need it:

为编辑器中的 Head 及段落增加了 Tab 键缩进的扩展,并为代码块增加了缩进。可以使用 Tab 键进行缩进,使用 Shift + Tab 组合键进行缩进回退。

How to test it?

  1. 检查标题及普通段落是否能够正常进行缩进以及撤销缩进。
  2. 使用代码块,查看是否能够正常进行缩进以及撤销缩进。
  3. 检查其他编辑器组件是否会被影响。

上述部分均可测试选中部分内容及光标焦点位置,查看是否符合预期。

Which issue(s) this PR fixes:

See #4447
See #4380

Does this PR introduce a user-facing change?

编辑器标题、段落及代码块增加 Tab 快捷键缩进

@f2c-ci-robot f2c-ci-robot bot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 24, 2023
@vercel
Copy link

vercel bot commented Aug 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
richtext-editor ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 24, 2023 9:46am

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 24, 2023
Copy link
Contributor

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 25, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Aug 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 098df3d into halo-sigs:main Aug 25, 2023
3 checks passed
f2c-ci-robot bot pushed a commit to halo-dev/halo that referenced this pull request Aug 25, 2023
#### What type of PR is this?

/area console
/kind cleanup
/milestone 2.9.x

#### What this PR does / why we need it:

升级默认编辑器的版本,包含以下修改:

1. 图片支持修改 alt 属性。 halo-sigs/richtext-editor#32
2. 拖拽修改图片大小的时候保持等比例。 halo-sigs/richtext-editor#33
3. 优化在移动端下,编辑器右侧边栏的样式。 halo-sigs/richtext-editor#35
4. 编辑器标题、段落及代码块增加 Tab 快捷键缩进。 halo-sigs/richtext-editor#34

#### Does this PR introduce a user-facing change?

```release-note
升级默认编辑器的版本,包含以下更改:

1. 图片支持修改 alt 属性。 by @GodlessLiu in <halo-sigs/richtext-editor#32>
2. 拖拽修改图片大小的时候保持等比例。 by @GodlessLiu in <halo-sigs/richtext-editor#33>
3. 优化在移动端下,编辑器右侧边栏的样式。 by @ruibaby in <halo-sigs/richtext-editor#35>
4. 编辑器标题、段落及代码块增加 Tab 快捷键缩进。 by @LIlGG in <halo-sigs/richtext-editor#34>
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants