feat: implement functionality of column cards #40
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
普通组件通常只有点击之后选中才处于活动状态。而组件变为 iframe 后,只要悬停就会获取焦点并处于活动状态。而弹出分栏的菜单是因为监听到了当前分栏处于活动状态从而出现。 由于 iframe 实际上不容易触发点击事件,容易与嵌入的资源产生误触,因此我认为这个操作是可以接受的。不过或许还有其他更好的方式,可以一起讨论一下。 |
修改了一下 bubble 菜单的逻辑,现在移入 iframe 应该还会显示菜单,但不会与分栏的菜单重叠。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
为编辑器增加分栏卡片的功能
How to test it?
测试新增分栏卡片的功能是否可用。
查看 console 端打印的 HTML 结构是否正常。
Which issue(s) this PR fixes:
Fixes #30
Fixes halo-dev/halo#2798
Ref halo-dev/halo#4380
Does this PR introduce a user-facing change?