Skip to content
This repository has been archived by the owner on Nov 29, 2023. It is now read-only.

fix: solve the command menu scrolling issue #41

Merged
merged 3 commits into from Sep 13, 2023

Conversation

LIlGG
Copy link
Contributor

@LIlGG LIlGG commented Sep 8, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

优化 commands menu 使用快捷键滚动的问题,原先使用快捷键滚动会同步导致父窗口进行滚动。

How to test it?

  1. 编辑多行文本,直至编辑器出现滚动条。
  2. 按 / 打开 commands menu,使用上下快捷键滚动,查看父窗口是否会跟随滚动

Does this PR introduce a user-facing change?

优化 commands menu 使用快捷键滚动时编辑器会跟随滚动的问题。

@vercel
Copy link

vercel bot commented Sep 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
richtext-editor ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 8, 2023 9:16am

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Sep 8, 2023
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2023
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Sep 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 849af07 into halo-sigs:main Sep 13, 2023
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants