Skip to content
This repository has been archived by the owner on Nov 29, 2023. It is now read-only.

fix: resolve the issue of incomplete coverage of text highlight #56

Merged
merged 2 commits into from Sep 26, 2023

Conversation

LIlGG
Copy link
Contributor

@LIlGG LIlGG commented Sep 26, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

为高亮 html 设置 display: inline-block 样式,解决由于设置了文本大小之后,再设置个高亮所导致高亮显示不完全的问题。

How to test it?

  1. 为文本设置大小
  2. 为文本设置高亮
  3. 查看高亮背景是否展示完全

Which issue(s) this PR fixes:

Fixes halo-dev/halo#4653

Does this PR introduce a user-facing change?

解决文本高亮显示不完全的问题

@vercel
Copy link

vercel bot commented Sep 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
richtext-editor ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2023 8:06am

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Sep 26, 2023
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

image

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2023
Copy link
Contributor

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works very well.

image

/lgtm

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Sep 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 7556cc3 into halo-sigs:main Sep 26, 2023
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

高亮文字效果不好
3 participants