Delayed Disqus comments #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I love this feature, and greatly appreciate the preview! I have a request: can you translation for the other language .yaml files as well? I think a google translation of the word "show" to each language is all that's needed. The word "comments" can be reused from the "moreComment" id. |
|
Done |
|
Thank you very much! |
shantanugoel
pushed a commit
to shantanugoel/beautifulhugo
that referenced
this pull request
Dec 30, 2019
Delayed Disqus comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an option to load the Disqus comments on demand when the user clicks a button. It saves the users a ton of network requests when they do not care about comments (or there are none for a post).
More info in my blog post Delaying Disqus comments to save (a ton of) requests where you can also see it in action.