Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define subtitle file naming #426

Closed
inter5tella opened this issue Jan 22, 2022 · 5 comments
Closed

Define subtitle file naming #426

inter5tella opened this issue Jan 22, 2022 · 5 comments

Comments

@inter5tella
Copy link

Is your feature request related to a problem? Please describe.
The default subtitle file naming is not working for all common encoding applications. Some of them do require a specific naming to get recognized.

Describe the solution you'd like
Instead of naming the subtitle files in their native language, it should be possible to name them in ISO639-1, ISO639-2, and English. i.e. Deutsch should be named as 'German'.

Describe alternatives you've considered
An alternative would be to define a hard-coded language code (or template) for the preferred encoding software.

Additional context
This has been tested on Staxrip, where 'xxxxxx.Deutsch.ass' was not being recognized, but 'xxxxx.German.ass' was indicated in Staxrip to define the subtitle file to the language of German.
@hama3254
Copy link
Owner

hama3254 commented Jan 23, 2022 •
edited

i already use the ISO639-2 for the "merge subs" option but i can't find a ISO Code for Español (Latin America) so i use the same as for Español (España) which was ok for that because i can add titles for the merged subs.

Images

grafik
grafik

so i did it like that with the option to use either option or both.
grafik

@inter5tella
Copy link
Author

Hi hama,
thanks for your reply.

Is the last screenshot of you made from an already existing CR version or is it a POC?

@hama3254
Copy link
Owner

Is the last screenshot of you made from an already existing CR version or is it a POC?

i just finished the release you can find it here but it is somewhat untested especially for funimation.

hama3254 added a commit that referenced this issue Jan 23, 2022
@hama3254
reorganized the settings for #426 and #425 (to be done)
c798a52 
 * changed `Hybrid Mode` from checkbox to drop down menu
 * moved `Hybrid Mode` to `Output` page
 * moved `redirect mult-download` to output page
 * added `Naming` page
 * moved all filenname option to `Naming` page
 * added subfile naming options for `ISO639-2` and `Crunchyroll name + ISO639-2` #426
@inter5tella
Copy link
Author

I've tested U12 and is working well so far. But is it also possible to output the Crunchyroll subtitle file naming in English instead of its native language? i.e. output German instead of Deutsch.
I guess by that, every possible scenario is covered depending on which encoding software is used by the user and how they recognize the subtitle's language.

@hama3254
Copy link
Owner

That would be possible but the option is already only useful for just a minority at best so there would be close to no point to add that.

@hama3254 hama3254 mentioned this issue Oct 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@inter5tella @hama3254