Fix advanced settings #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
customvalues --> advanced_settings
Updated for `advanced_settings`
|
Thanks very much for your contribution. |
albers
requested changes
Dec 14, 2021
There was a problem hiding this comment.
I did some research:
advanced_settings was added to vmware_guest in the 1.8.0 release of the community.vmware collection.
This release is part of the Ansible community package 3.2.0, which is based on ansible-core 2.10.7 (see build data).
Because this change is a breaking one, min_ansible_version will have to be changed to 2.10.7 here.
Please also change the requirements section to
"The minimum community.vmware collection version is 1.8.0, which is part of the Ansible community package 3.2.0."
Updated documentation to be vSphere 7.0 Updated documentation to reflect new minimum requirements Updated galaxy metadata for new minimum Ansible version
dotalchemy
commented
Dec 22, 2021
albers
approved these changes
Dec 22, 2021
|
@dotalchemy released v6.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a thing introduced by a change made to the 'community.vmware' collection where
customsettingswas replaced withadvanced_settingsin a recent release of the collection.This caused the role to fail with
Unable to find custom value key disk.EnableUUIDSee Github Issue #179
See vmware_guest_module
Tested on whatever version of Ansible is in the very latest AWX Operator build, but there shouldn't be a version dependency change as it's just a string edit in the yaml to match what
community.vmwareis expecting.