Paginator tests

hamburgscleanest · Jun 15, 2017 · 3dacb73 · 3dacb73
1 parent 0bbbf05
commit 3dacb73
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/Models/DataComponents/Paginator.php b/src/Models/DataComponents/Paginator.php
@@ -190,7 +190,7 @@ private function _getEndPage() : int
      */
     public function pageCount() : int
     {
-        if ($this->_perPage === 0)
+        if (empty($this->_perPage))
         {
             return 1;
         }
@@ -248,7 +248,7 @@ private function _getLastPageUrl() : ? string
      */
     protected function _shapeData() : Builder
     {
-        if ($this->_perPage === 0)
+        if (empty($this->_perPage))
         {
             return $this->_dataTable->query();
         }

diff --git a/tests/PaginationTest.php b/tests/PaginationTest.php
@@ -44,9 +44,11 @@ public function has_only_one_page_when_per_page_is_zero()
         /** @var Paginator $paginator */
         $paginator = new Paginator(0);
 
-        DataTable::model(TestModel::class, ['id', 'created_at', 'name'])
+        $dataTable = DataTable::model(TestModel::class, ['id', 'created_at', 'name'])
             ->addComponent($paginator);
 
+        $dataTable->render();
+
         $this->assertEquals(1, $paginator->pageCount());
     }