Add retry option to curl when uploading certificates #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
March 26, 2017 18:21
Add a retry option in case curl fails
Fix updating the wrong variable
Move counter update to the end of the loop, so our counter logic is valid
Add options to curl to hide the progress bar but show errors which can be helpful
Move counter back to the beginning as this avoids any logic in the print statement
Move sleep statement to avoid unnecessary sleep
|
Thanks! This looks good, will accept the pull request. Can't test it right now but it looks perfect 👍 When I find some time to test it I will make a new release. |
|
Thanks! |
|
https://hub.docker.com/r/hamburml/docker-flow-letsencrypt/tags/ Latest-Tag is already newest version. |
|
Thanks for the new release, works like a charm! |
|
@hamburml it would be great if you could release as a version number as well.. maybe 1.2 |
|
@patrickleet Will do. The master branch is automatically build by docker-cloud as latest tag. That's the reason why I mentioned it. Will create the tag right now. v0.1.2 is now available https://hub.docker.com/r/hamburml/docker-flow-letsencrypt/tags/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using docker swarm it can happen that a docker-flow-letsencrypt container starts before a docker-flow-proxy container. When that is the case curl fails (stating it is unable to resolve host ...). So I added a retry mechanism and curl will try again if it fails.