Fixed bug in retry logic, updated to Bionic and updated certbot #51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was impacted by a bug in the retry login in
certbot.sh
that would lead to a domain being skipped if it the certbot dry-run did not succeed on the first attempt (this was common in my case, for a service that was launching at the same time as this container). In short, thebreak
statement would prevent$exitcode
being set, which means that even when the dry-run eventually succeeded, this success was not detected. To fix this I refactored the logic a little.In addition, I had to replace the
certbot-auto
script, which is now deprecated and no longer works on Debian systems. While I was at it, I also upgraded to Ubuntu 18.04 LTS.