Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong type annotation for IsDictContainingEntries.describe_keyvalue #182

Closed
rittneje opened this issue Aug 25, 2021 · 1 comment
Closed
Assignees

Comments

@rittneje
Copy link

def describe_keyvalue(self, index: int, value: V, description: Description) -> None:
"""Describes key-value pair at given index."""
description.append_description_of(index).append_text(": ").append_description_of(value)

Isn't the type of index (which should really have been named key) actually K, not int?

@brunns
Copy link
Member

brunns commented Aug 26, 2021

Good catch. Not too urgent an issue, mind you, since I can't see the describe_keyvalue() method being used other than internally by the class itself.

@brunns brunns self-assigned this Mar 3, 2022
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue Nov 5, 2023
Hamcrest 2.1.0 (2023-10-22)
===========================

Features
--------

- Add a matcher for exceptions in asyncio future (`#171 <https://github.com/hamcrest/PyHamcrest/issues/171>`_)


Bugfixes
--------

- Use the correct generic type in the internal ``describe_keyvalue`` method (`#182 <https://github.com/hamcrest/PyHamcrest/issues/182>`_)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants