Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return result of a deferred call #62

Closed
wants to merge 1 commit into from
Closed

Return result of a deferred call #62

wants to merge 1 commit into from

Conversation

SUNx2YCH
Copy link

In my custom matcher based on Raises I need a deferred call result to create a meaningful mismatch description (when there was no exception raised). That's why I think that DeferredCallable.__call__() should have a return statement.
I'm pretty sure that this change will not break anything.
Also I have removed a couple of unused imports.

@SUNx2YCH
Copy link
Author

There is an issue with py32 env:
https://bitbucket.org/ned/coveragepy/issues/407/coverage-failing-on-python-325-using
Will try to fix it.

@SUNx2YCH
Copy link
Author

It turns out that pip 8 also dropped support for Python 3.2: travis-ci/travis-ci#5485
That was the main reason of py32 env fail.

@offbyone
Copy link
Member

offbyone commented Mar 5, 2016

I'm going to revisit Python 2.6 support before merging this. Probably do that this weekend.

@SUNx2YCH
Copy link
Author

SUNx2YCH commented Mar 5, 2016

BTW, py32 env could be fixed by downgrading virtualenv and coverage:
https://travis-ci.org/SUNx2YCH/PyHamcrest/builds/112275490
I can create a pull request if you choose to continue with Python 3.2 support.

@offbyone
Copy link
Member

offbyone commented Mar 5, 2016

Thanks, I'll just do the downgrade as part of the merge.

@offbyone
Copy link
Member

offbyone commented Mar 5, 2016

Pushed as 1.9.0

@offbyone offbyone closed this Mar 5, 2016
@SUNx2YCH
Copy link
Author

SUNx2YCH commented Mar 6, 2016

Thanks!

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 96.085% when pulling d37dbc0 on SUNx2YCH:raises_fix into a9718b2 on hamcrest:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants