Skip to content

Commit

Permalink
fix: get-app on existing apps
Browse files Browse the repository at this point in the history
get-app to replace existing folder would fail due to bad url generation.

Changes
* Archive old repo instead of overwritting
* Resetting flags in App instance
  • Loading branch information
gavindsouza committed Jul 27, 2022
1 parent beac865 commit e03f597
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion bench/app.py
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,9 @@ def remove(self, no_backup: bool = False):
shutil.move(active_app_path, archived_app_path)
log(f"App moved from {active_app_path} to {archived_app_path}")

self.from_apps = False
self.on_disk = False

@step(title="Installing App {repo}", success="App {repo} Installed")
def install(
self,
Expand Down Expand Up @@ -419,7 +422,7 @@ def get_app(
"Do you want to continue and overwrite it?"
)
):
shutil.rmtree(cloned_path)
app.remove()
to_clone = True

if to_clone:
Expand Down

0 comments on commit e03f597

Please sign in to comment.